[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62416: 30.0.50; Symbols skipped in the navigation in ruby-ts-mode
From: |
Juri Linkov |
Subject: |
bug#62416: 30.0.50; Symbols skipped in the navigation in ruby-ts-mode |
Date: |
Tue, 28 Mar 2023 09:31:52 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>> This will break other cases, e.g.
>> b = %Q{This is a "string"}
>> c = %w!foo
>> bar
>> baz!
>> d = %(hello (nested) world)
>> when point is after "b", 'C-M-f' will move to "c" instead of the end of
>> line.
>
> That is because the string literals aren't recognized as sexps yet. Try
> this:
>
> @@ -1129,8 +1129,11 @@ ruby-ts-mode
> "block"
> "do_block"
> "begin"
> - "binary"
> - "assignment")))
> + "integer"
> + "simple_symbol"
> + "string"
> + "string_array"
> + )))
Thanks, this definitely is an improvement since it handles all mentioned cases.
However, there are still a lot of more things that need fixing.
When point is on the left curly bracket in
b = %Q{This is a "string"}
'C-M-f' doesn't move to the right curly bracket.
Also double quotes inside the string are not matched by 'C-M-f'.
In
d = %(hello (nested) world)
'C-M-f' doesn't move to the closing parens from opening parens.
Looking at test/lisp/progmodes/ruby-mode-resources/ruby.rb
for example here curly brackets are not matched with 'C-M-f C-M-b'
in string interpolation and regexps:
"abc/#{ddf}ghi"
/foo/xi != %r{bar}mo.tee
Do you think it is possible to handle these cases
by crafting treesit-sexp-type-regexp?
bug#62416: 30.0.50; Symbols skipped in the navigation in ruby-ts-mode, Yuan Fu, 2023/03/30