[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
From: |
Konrad Podczeck |
Subject: |
bug#62234: Toolbar does not work properly (with Emacs 29 or 30) |
Date: |
Sat, 18 Mar 2023 12:07:39 +0100 |
After playing around a little bit, I confirm that Emacs now works as expected.
Thanks for your effort,
konrad
> Am 18.03.2023 um 11:25 schrieb Daniel Martín <mardani29@yahoo.es>:
>
> Po Lu <luangruo@yahoo.com> writes:
>
>>> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
>>> +{
>>> + return [toolbarItem isEnabled];
>>> +}
>>> +
>>
>> This does no harm on GNUstep. However, please indent with two spaces,
>> and place spaces after -, :, and ):
>>
>> - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
>> {
>> return [toolbarItem isEnabled];
>> }
>>
>> Otherwise, LGTM. Thanks.
>
> OK, I've attached a new version of the patch. Konrad, could you check
> if with this patch the Emacs toolbar works as you expect? Thanks.
>
> <0001-Fix-toolbar-item-validation-in-the-NS-port.patch>
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Po Lu, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Po Lu, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/18
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30),
Konrad Podczeck <=
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/23
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/23
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17