bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60703: Patches to xwidget code


From: Andrew De Angelis
Subject: bug#60703: Patches to xwidget code
Date: Sat, 4 Mar 2023 18:00:03 -0500

Awesome, thank you so much! Will keep all your suggestions in mind for my future contributions.

Small question: what are the criteria to be added to `etc/AUTHORS`? Just wondering if/how my contribution could be mentioned there.

On Thu, Mar 2, 2023 at 5:58 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Andrew De Angelis <bobodeangelis@gmail.com>
> Date: Thu, 23 Feb 2023 22:47:41 -0500
> Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org
>
> Let me know if this ChangeLog is fine or you'd like me to make any changes.

Thanks, installed on the emacs-29 branch, and closing the bug.

>  The first line of a doc string should be a single complete sentence.
>
> I'm not sure I follow: in this case, isn't  this the first line: "Get the estimated load progress of XWIDGET, a
> WebKit widget."? It renders fine when I run `M-x apropos xwidget-webkit-estimated-load-progress`. But
> happy to make any additional changes if needed.

Please ignore that part: I was confused.

Please in the future always accompany the changes with a
ChangeLog-style commit log message, and mention the bug number there
if you know it.  Also, use of "git format-patch" is encouraged.  These
measures make the job of installing your changes much easier.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]