bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node


From: Stefan Monnier
Subject: bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node
Date: Thu, 02 Mar 2023 15:24:07 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

>> diff --git a/src/profiler.c b/src/profiler.c
>> index 81b5e7b0cf0..c99ed0a81a2 100644
>> --- a/src/profiler.c
>> +++ b/src/profiler.c
>> @@ -505,6 +505,8 @@ DEFUN ("profiler-memory-log",
>>  void
>>  malloc_probe (size_t size)
>>  {
>> +  if (EQ (backtrace_top_function (), QAutomatic_GC))
>> +    return;                     /* bug#60237 */
>>    eassert (HASH_TABLE_P (memory_log));
>>    record_backtrace (XHASH_TABLE (memory_log), min (size, 
>> MOST_POSITIVE_FIXNUM));
>>  }
>
> Shouldn't this be:
>
>   if (gc_in_progress)
>     return;

Sounds like a good idea.  If so that should apply to the cpu profiler
code as well.  It might be worthwhile to check the details to see if
there might be subtle differences (e.g. when we're running
`post-gc-hook` maybe?).


        Stefan






reply via email to

[Prev in Thread] Current Thread [Next in Thread]