[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node
From: |
Eli Zaretskii |
Subject: |
bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node |
Date: |
Wed, 01 Mar 2023 15:27:26 +0200 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: casouri@gmail.com, luangruo@yahoo.com, mickey@masteringemacs.org,
> 60237@debbugs.gnu.org
> Date: Tue, 28 Feb 2023 23:07:47 -0500
>
> >> > Stefan, could it be a problem for us if garbage-collecting an object
> >> > calls xmalloc? Including if the "memory" profiler is running at the
> >> > time of that GC?
> >>
> >> I can't think of a fundamental reason why this would be a problem, but
> >> as you've seen some code may not be quite ready for it.
> >>
> >> I suspect the simplest solution is to do something like what we do
> >> for the cpu-profiler, i.e. handle the "time within GC" specially by
> >> checking (EQ (backtrace_top_function (), QAutomatic_GC)) to determine
> >> that we're within the GC.
> >
> > Any reason not to install the patch that uses gcsize instead of ASIZE?
>
> That might work, but I suspect there's a good reason why I used
> `cpu_gc_count`. I think running the "normal" profiling code during GC
> can cause other problems than just ASIZE because it can/will change
> ELisp objects, and modifying the heap while we're doing GC is the
> problem that concurrent GCs try to solve: our GC is not equipped
> for that.
Would you mind installing a change along these lines on the emacs-29
branch? I'm not familiar enough with profiler.c to experiment with
its code on the release branch.
TIA
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node,
Eli Zaretskii <=
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Stefan Monnier, 2023/03/01
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Eli Zaretskii, 2023/03/01
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Stefan Monnier, 2023/03/01
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Eli Zaretskii, 2023/03/04
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Stefan Monnier, 2023/03/08
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Stefan Monnier, 2023/03/10
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Stefan Monnier, 2023/03/10
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Eli Zaretskii, 2023/03/11
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Stefan Monnier, 2023/03/11
- bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node, Po Lu, 2023/03/10