[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61460: 30.0.50; Calendar shows eclipse for quarter moon
From: |
Michael Heerdegen |
Subject: |
bug#61460: 30.0.50; Calendar shows eclipse for quarter moon |
Date: |
Wed, 22 Feb 2023 11:03:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Ulrich Mueller <ulm@gentoo.org> writes:
> It is probably a matter of personal taste, but I dislike the nested
> concats. This seems simpler (not tested, though):
>
> - (cons mark (concat (lunar-phase-name (nth 2 phase)) " "
> - (cadr phase))))))
> + (cons mark
> + (let ((eclipse (nth 3 phase)))
> + (concat (lunar-phase-name (nth 2 phase)) " "
> + (cadr phase)
> + (if (string-empty-p eclipse) "" " ")
> + eclipse))))))
Fine by me (my preference would be Andreas' suggestion).
We also need to fix the space handling in calendar-lunar-phases aka M in
calendar - when no eclipse occurs, the descriptions end with a
trailing space.
Michael.
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, (continued)
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Müller, 2023/02/16
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/17
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Müller, 2023/02/17
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/17
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/18
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Mueller, 2023/02/18
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/18
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/21
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Mueller, 2023/02/22
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Andreas Schwab, 2023/02/22
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon,
Michael Heerdegen <=
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Mueller, 2023/02/22
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/22
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Mueller, 2023/02/22
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/22
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/25
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Eli Zaretskii, 2023/02/14
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Mueller, 2023/02/14
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Ulrich Mueller, 2023/02/13
- bug#61460: 30.0.50; Calendar shows eclipse for quarter moon, Michael Heerdegen, 2023/02/13