[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER
From: |
João Távora |
Subject: |
bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER |
Date: |
Mon, 20 Feb 2023 09:30:41 +0000 |
On Mon, Feb 20, 2023 at 9:22 AM Basil L. Contovounesios <contovob@tcd.ie> wrote:
>
> João Távora [2023-02-19 19:38 +0000] wrote:
> > The only nit I would point out is that there seems to be some
> > unrelated housekeeping already in the first patch that could
> > be moved to the second patch, or maybe a separate commit.
>
> You mean, the indentation and commentary fixes? The impression I got is
> that these kinds of changes are more welcome in emacs.git when the
> surrounding code is already being touched, as opposed to making small
> whitespace-only changes to functions that are not otherwise being
> changed.
Those cosmetic changes are most welcome. But my personal
preference is to do them in a separate commit, so that when you
inspect and try to understand a "functional" commit, you are
presented with only just behavior-changing changes, which
makes the commit easier to understand.
But this is just a nit.
> I have little personal preference either way.
>
> > The yasnippet-related fix could also be its own commit. But
> > again, that's only a minor nit.
>
> Sure, I can break out the autopep8 and YASnippet changes if that's
> preferred.
Again, this is just a nit.
João