[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of mul
From: |
Eli Zaretskii |
Subject: |
bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions |
Date: |
Sun, 05 Feb 2023 11:20:27 +0200 |
> Cc: 61142@debbugs.gnu.org
> Date: Sun, 05 Feb 2023 08:53:33 +0100
> From: Theodor Thornhill via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Theodor Thornhill <theo@thornhill.no> writes:
>
> > 太阳 <zjyzhaojiyang@hotmail.com> writes:
> >
> >> After reading treesit's manual, I found that we can use `n-p-gp` as the
> >> matcher
> >> and `grand-parent` as the anchor to match the body of `if` (and `while`,
> >> which
> >> has a similar issue).
> >>
> >> I mean a rule looks like the following:
> >>
> >> ```
> >> ((n-p-gp nil "block" "if_statement") grand-parent
> >> java-ts-mode-indent-offset)
> >> ```
> >>
> >>
> >
> >
> > Thanks! We have a mechanism in place for this, see
> > 'c-ts-common-statement-offset' in 'c-ts-common.el'. I didn't get to it
> > yet, but I'll try to look at it this evening, unless you want to? See
> > c-ts-mode for examples of how to use it, if you're interested!
> >
> > Theo
>
> Hi again!
>
> Can you test this patch for me?
>
> @Eli: Is this ok for emacs-29? I'd love to add some test for this, but
> now they are on the master branch. What is the common procedure to move
> stuff from master branch to the release branch? I _can_ just add some
> test to the master branch, but it would be nice to have them on emacs-29
> too :-)
The procedure is "git cherry-pick", but I don't think I understand
what exactly is the problem here and what is the solution suggested to
solve it. Also, why does it need to be on emacs-29. Can you help me
understand that?
Thanks.
- bug#61142: Acknowledgement (29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions), 太阳, 2023/02/01
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/04
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions,
Eli Zaretskii <=
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Eli Zaretskii, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Eli Zaretskii, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, 赵 纪阳, 2023/02/06
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Eli Zaretskii, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05