[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54603: 29.0.50; [PATCH] Eshell's external pipe module interferes wit
From: |
Sean Whitton |
Subject: |
bug#54603: 29.0.50; [PATCH] Eshell's external pipe module interferes with other argument parsing hooks |
Date: |
Thu, 31 Mar 2022 15:48:33 -0700 |
User-agent: |
Emacs/29.0.50 (x86_64-pc-linux-gnu) |
Hello,
On Thu 31 Mar 2022 at 03:19pm -07, Jim Porter wrote:
> This could probably be resolved with some additional logic (setting
> `eshell-current-argument' as appropriate?), but I hope there's a
> cleaner way that doesn't involve reimplementing
> `eshell-parse-argument' within `eshell-parse-external-pipeline'.
Well, quite.
Thank you for testing. In the meantime, I've thought it all through
some more, and I think that your original idea of catching the
'eshell-incomplete is the right thing, assuming all tests pass.
I think the error should be caught inside the `or', though? The idea
would be that if eshell-incomplete is thrown within one of the
disjuncts, that disjunct should return nil.
--
Sean Whitton