[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22324: 25.0.50; completion-category-defaults style doesn't override
From: |
Lars Ingebrigtsen |
Subject: |
bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) |
Date: |
Mon, 24 Jan 2022 10:46:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> So the fix I had in mind looks like:
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index d58c23af8f..0aee55f33c 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -1043,7 +1043,7 @@ completion--styles
> (let* ((cat (completion-metadata-get metadata 'category))
> (over (completion--category-override cat 'styles)))
> (if over
> - (delete-dups (append (cdr over) (copy-sequence completion-styles)))
> + (cdr over)
> completion-styles)))
Oh, I see. Hm... that would change the behaviour for those that depend
on this working the old way.
Perhaps it'd make more sense to add a new variable to allow real overrides?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Lars Ingebrigtsen, 2022/01/21
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Dmitry Gutov, 2022/01/23
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead),
Lars Ingebrigtsen <=
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Dmitry Gutov, 2022/01/24
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Lars Ingebrigtsen, 2022/01/25
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Dmitry Gutov, 2022/01/25
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Daniel Mendler, 2022/01/25
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Stefan Monnier, 2022/01/26
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Daniel Mendler, 2022/01/26
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Stefan Monnier, 2022/01/26
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Daniel Mendler, 2022/01/26
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Stefan Monnier, 2022/01/26
- bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead), Daniel Mendler, 2022/01/26