[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in con
From: |
Juri Linkov |
Subject: |
bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu |
Date: |
Sat, 15 Jan 2022 20:57:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> It's not just for `elisp-mode'; any mode (or other third-party code) may
> want to insert context menu items in a certain spot. `middle-separator'
> follows the naming convention I recommend, but a hypothetical mode might
> want to insert a new item just after the separator for the Undo
> section. However, that's currently named `separator-undo' on master, so it
> can be confusing to remember the difference in naming between these two
> cases:
>
> (define-key-after menu [my-separator] menu-bar-separator
> 'middle-separator)
>
> (define-key-after menu [my-separator] menu-bar-separator
> 'separator-undo)
If it's too late to push this to the release branch,
then this definitely can't be done after the release.
So probably this bug report should be closed?
Meanwhile, I noticed another inconsistency
where context menus for some modes are named
with the -mode suffix, and some without it.
With `-mode':
lisp/help-mode.el
(defun help-mode-context-menu (menu click)
lisp/textmodes/text-mode.el
(defun text-mode-context-menu (menu click)
Without `-mode':
lisp/progmodes/prog-mode.el
(defun prog-context-menu (menu click)
lisp/progmodes/elisp-mode.el
(defun elisp-context-menu (menu click)
Maybe it's too late to fix this inconsistency too?
- bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu,
Juri Linkov <=