[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52951: Including Swedish calendar localization (sv-kalender.el) in E
From: |
Mattias Engdegård |
Subject: |
bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs |
Date: |
Wed, 5 Jan 2022 10:54:43 +0100 |
> http://bigwalter.net/daniel/elisp/sv-kalender.el
Thank you!
> (setq calendar-time-display-form
> '(24-hours ":" minutes))
Standard Swedish style uses a dot as separator; the colon appears to have crept
in as a fairly recent Anglicism (and I think it looks a bit tacky).
The file should also use lexical-binding: t.
> (eval-after-load "solar"
We should probably use `with-eval-after-load`.
> (eval calendar-location-name)
Would `symbol-value` do instead of `eval` here?
> '((if (fboundp 'atan)
I think we can assume the presence of `atan`.
> (funcall 'holiday-sexp calendar-daylight-savings-starts
> (funcall 'holiday-sexp calendar-daylight-savings-ends
Why the explicit `funcall`s? Is this a holiday code subtlety?
By the way, is there a way to do without the defadvice? They tend to be brittle.