From ed1e061961cfc3eba7d692f93e5fbb70e7df4760 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Tue, 7 Dec 2021 14:46:34 +0100 Subject: [PATCH] Remove bad-packages-alist * lisp/simple.el (bad-packages-alist, bad-package-check): Remove. --- lisp/simple.el | 51 -------------------------------------------------- 1 file changed, 51 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 84928caa31..d9845dc3cd 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -9783,57 +9783,6 @@ messages-buffer ;; (list 'modification-hooks '(minibuffer-prompt-modification) ;; 'insert-in-front-hooks '(minibuffer-prompt-insertion))) - -;;;; Problematic external packages. - -;; rms says this should be done by specifying symbols that define -;; versions together with bad values. This is therefore not as -;; flexible as it could be. See the thread: -;; https://lists.gnu.org/r/emacs-devel/2007-08/msg00300.html -(defconst bad-packages-alist - ;; Not sure exactly which semantic versions have problems. - ;; Definitely 2.0pre3, probably all 2.0pre's before this. - '((semantic semantic-version "\\`2\\.0pre[1-3]\\'" - "The version of `semantic' loaded does not work in Emacs 22. -It can cause constant high CPU load. -Upgrade to at least Semantic 2.0pre4 (distributed with CEDET 1.0pre4).") - ;; CUA-mode does not work with GNU Emacs version 22.1 and newer. - ;; Except for version 1.2, all of the 1.x and 2.x version of cua-mode - ;; provided the `CUA-mode' feature. Since this is no longer true, - ;; we can warn the user if the `CUA-mode' feature is ever provided. - (CUA-mode t nil -"CUA-mode is now part of the standard GNU Emacs distribution, -so you can now enable CUA via the Options menu or by customizing `cua-mode'. - -You have loaded an older version of CUA-mode which does not work -correctly with this version of Emacs. You should remove the old -version and use the one distributed with Emacs.")) - "Alist of packages known to cause problems in this version of Emacs. -Each element has the form (PACKAGE SYMBOL REGEXP STRING). -PACKAGE is either a regular expression to match file names, or a -symbol (a feature name), like for `with-eval-after-load'. -SYMBOL is either the name of a string variable, or t. Upon -loading PACKAGE, if SYMBOL is t or matches REGEXP, display a -warning using STRING as the message.") - -(defun bad-package-check (package) - "Run a check using the element from `bad-packages-alist' matching PACKAGE." - (condition-case nil - (let* ((list (assoc package bad-packages-alist)) - (symbol (nth 1 list))) - (and list - (boundp symbol) - (or (eq symbol t) - (and (stringp (setq symbol (eval symbol))) - (string-match-p (nth 2 list) symbol))) - (display-warning package (nth 3 list) :warning))) - (error nil))) - -(dolist (elem bad-packages-alist) - (let ((pkg (car elem))) - (with-eval-after-load pkg - (bad-package-check pkg)))) - ;;; Generic dispatcher commands -- 2.30.2