[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52855: vc-shrink-buffer
From: |
Juri Linkov |
Subject: |
bug#52855: vc-shrink-buffer |
Date: |
Wed, 29 Dec 2021 10:23:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> When no shrink is needed, two new hooks are added in this patch
>> with the default value containing vc-shrink-buffer to preserve
>> the current behavior that can be easily removed in user configuration
>> by e.g.:
>> (remove-hook 'vc-diff-finish-functions 'vc-shrink-buffer)
>> (remove-hook 'vc-log-finish-functions 'vc-shrink-buffer)
>
> So the idea is to allow customizing this behavior off?
>
> For those users who don't see the benefits?
What for one is a benefit, for others is an annoyance.
> LGTM.
Before pushing I only have a doubt about 'vc-shrink-buffer'.
Currently it's a wrapper around 'shrink-window-if-larger-than-buffer'
that has nothing to do with vc:
(defun vc-shrink-buffer (&optional buffer)
"Call `shrink-window-if-larger-than-buffer' only when BUFFER is visible.
BUFFER defaults to the current buffer."
(let ((window (get-buffer-window buffer t)))
(when window
(shrink-window-if-larger-than-buffer window))))
Maybe it should be in window.el and renamed to
shrink-buffer-if-larger-than-buffer