bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#52826: vc-revert fails on non-default buffer name


From: Dmitry Gutov
Subject: bug#52826: vc-revert fails on non-default buffer name
Date: Tue, 28 Dec 2021 02:32:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 27.12.2021 20:53, Juri Linkov wrote:
When such customization is used:

   (add-hook 'diff-mode-hook 'rename-uniquely)

that uniquely renames*vc-diff*  to*vc-diff*<number>,
then 'vc-revert' completely breaks up because of the hard-coded buffer name.
This patch should fix it:

diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 9fc9169821..5a99025289 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -2785,7 +2785,7 @@ vc-revert
      (unwind-protect
        (when (if vc-revert-show-diff
                  (progn
-                   (setq diff-buffer (generate-new-buffer-name "*vc-diff*"))
+                   (setq diff-buffer (generate-new-buffer "*vc-diff*"))
                    (vc-diff-internal vc-allow-async-revert vc-fileset
                                      nil nil nil diff-buffer))
                ;; Avoid querying the user again.

If this help, LGTM.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]