[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff bu
From: |
Eli Zaretskii |
Subject: |
bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers |
Date: |
Sun, 26 Dec 2021 18:21:42 +0200 |
> From: Matthias Meulien <orontee@gmail.com>
> Date: Sun, 26 Dec 2021 17:05:25 +0100
> Cc: 51809@debbugs.gnu.org
>
> Here is an updated patch implementing a default state for Outline mode
> and Outline minor mode:
Thanks, a few comments to the documentation parts:
> +If equal to a number, show only headings up to the corresponding
> +level.
"Up to and including" or "up to and excluding"?
Also, please make sure you leave 2 spaces between sentences in all the
doc strings and comments, per our conventions.
> + :type '(choice (const :tag "Disabled" nil)
It isn't clear what exactly is "disabled" under this value. The doc
string itself is also not clear about what happens when the value is
nil: "some headings are outlined" leaves me wondering what that means.
> +(defcustom outline-default-state-subtree-visibility nil
> + "Defines visibility of subtree starting at level defined by
> `outline-default-state'.
Not "Defines", "Determines".
Also, the first line is too long.
> +When equal to a list, each element is expected to equal one of:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"...should be one of the following:"
(Using "equal" here is not appropriate in any case, since you don't
always describe actual values.)
> +- A lambda function or function name which will be evaluated with
> + point at the beginningg of the heading and the match data set
^^^^^^^^^^
A typo.
And finally, I think this should have a NEWS entry.
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Matthias Meulien, 2021/12/11
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Juri Linkov, 2021/12/12
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Matthias Meulien, 2021/12/13
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Matthias Meulien, 2021/12/26
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Matthias Meulien, 2021/12/26
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Juri Linkov, 2021/12/27
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Juri Linkov, 2021/12/28
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Matthias Meulien, 2021/12/28
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Matthias Meulien, 2021/12/28
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Juri Linkov, 2021/12/28
- bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers, Matthias Meulien, 2021/12/28