bug#50160: 28.0.50; Wrong NSToolbarItem identifier

[Alan Third]

On Thu, Sep 09, 2021 at 09:59:28PM +0100, Alan Third wrote:
> On Fri, Sep 10, 2021 at 02:33:40AM +0900, tsuucat wrote:
> > 
> > > Ah, hmm... Perhaps we should append the label text to the hash or
> > > something?
> > 
> > I tried to append the label text to the hash. Most items fixed. But 
> > isearch.el uses “undo” icon and “Undo” label for isearch-delete-char item
> > so the tool-tip is wrong…
> > It is hard to set correct identifier because anyone can create toolbar 
> > items 
> > dynamically in Emacs lisp.
> > 
> > I noticed the current toolbaritem problem only matters label and tool-tip.
> > Executed commands are not wrong.
> 
> I suppose we could concatenate the hashes of all the values that might
> matter.

I've pushed a change to master that (I hope) does this.
-- 
Alan Third