bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#52491: 28.0.90; Regression in window deletion with minibuffer


From: Juri Linkov
Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer
Date: Tue, 21 Dec 2021 10:05:52 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)

>> Do you think this is safe enough to install on the release branch?
>
> Probably not.  I'm confused as to which posts made it today to the list.
> A correct patch is attached now and should be safe for Emacs 28.
>
> @@ -5167,7 +5167,10 @@ quit-restore-window
>      (cond
>       ;; First try to delete dedicated windows that are not side windows.
>       ((and dedicated (not (eq dedicated 'side))
> -           (window--delete window 'dedicated (eq bury-or-kill 'kill))))
> +           (window--delete window 'dedicated (eq bury-or-kill 'kill))
> +           (or (and (window-live-p (nth 2 quit-restore))
> +                 (select-window (nth 2 quit-restore)))
> +               t)))

Or maybe simply:

     ((and dedicated (not (eq dedicated 'side))
           (window--delete window 'dedicated (eq bury-or-kill 'kill)))
      ;; If the previously selected window is still alive, select it.
      (when (window-live-p (nth 2 quit-restore))
        (select-window (nth 2 quit-restore))))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]