[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52507: [PATCH] Option for vc-delete-file to keep file on disk
From: |
Ashwin Kafle |
Subject: |
bug#52507: [PATCH] Option for vc-delete-file to keep file on disk |
Date: |
Wed, 15 Dec 2021 18:34:31 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Ashwin Kafle <ashwin@ashwink.com.np> writes:
>> Also it looks that your another change is dangerous:
>>
>> (defun vc-git-delete-file (file)
>> - (vc-git-command nil 0 (vc-git--literal-pathspec file) "rm" "-f" "--"))
>> + (vc-git-command nil 0 (vc-git--literal-pathspec file) "rm" "-f"
>> "--cached" "--")))
>>
>> because it deletes the file in the staging area
>> that is not used by vc-git, so there is no way
>> to commit the deletion using vc commands.
>
> I think this check in vc-delete-file takes care of that
>
> (when (eq state 'edited)
> (error "Please commit or undo your changes before deleting %s" file))
Oh, you mean just that single commit can't be done by vc now. Yeah,
that seems true. Can you think of any solution for that here?
signature.asc
Description: PGP signature
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Ashwin Kafle, 2021/12/15
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Juri Linkov, 2021/12/15
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Ashwin Kafle, 2021/12/15
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Juri Linkov, 2021/12/15
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Ashwin Kafle, 2021/12/15
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk,
Ashwin Kafle <=
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Juri Linkov, 2021/12/16
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Dmitry Gutov, 2021/12/19
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Juri Linkov, 2021/12/23
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Dmitry Gutov, 2021/12/23
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Juri Linkov, 2021/12/26
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Dmitry Gutov, 2021/12/26
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Ashwin Kafle, 2021/12/26
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Ashwin Kafle, 2021/12/26
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Dmitry Gutov, 2021/12/26
- bug#52507: [PATCH] Option for vc-delete-file to keep file on disk, Ashwin Kafle, 2021/12/26