[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separ
From: |
Eli Zaretskii |
Subject: |
bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus |
Date: |
Sun, 12 Dec 2021 09:02:04 +0200 |
> Cc: 52293@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Sat, 11 Dec 2021 20:02:41 -0800
>
> > Yes. This way, we have quite some time before us to let people bump
> > into any problems this could cause and report back to us.
>
> That's ok by me. Note that this[1] is a very mildly incompatible change,
> so as long as people are aware of that, I think it should be ok to merge
> into 29, and hopefully into 28.2. The only incompatibility would be
> people wanting to add context menu items after certain specific
> separators like `global-separator' or `undo-separator'. I think that's
> fairly unlikely though, since:
>
> a) `context-menu-mode' is new so there aren't many (any?) third-party
> packages that use it yet.
>
> b) `context-menu-mode' doesn't guarantee that any particular items are
> actually present in the menu. Users can customize the context menu, so
> it could have anything at all in it. Relying on the presence of
> `global-separator' (however it's named) would be somewhat risky.
> `middle-separator' and `top-separator' (the latter is from the patch in
> this bug) are/will be at least *likely* to be present though, so are
> more likely to be used in third-party code.
Are you saying that we will be recommending a convention for separator
names only for menus popped up in context-menu-mode? Does it make
sense to have such a specialized convention? Isn't it possible to
show context menus outside of the context-menu-mode?
- bug#52293: 29.0.50; [PATCH v2] Prevent further cases of duplicated separators in context menus, (continued)
- bug#52293: 29.0.50; [PATCH v2] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/06
- bug#52293: 29.0.50; [PATCH v2] Prevent further cases of duplicated separators in context menus, Juri Linkov, 2021/12/07
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/07
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Eli Zaretskii, 2021/12/08
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/08
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Juri Linkov, 2021/12/08
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Eli Zaretskii, 2021/12/08
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Juri Linkov, 2021/12/09
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Eli Zaretskii, 2021/12/09
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/11
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus,
Eli Zaretskii <=
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/12
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Eli Zaretskii, 2021/12/12
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/12
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Eli Zaretskii, 2021/12/13
- bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/13
- bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Drew Adams, 2021/12/12
- bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/12
- bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/12
- bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Drew Adams, 2021/12/12
- bug#52293: [External] : bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus, Jim Porter, 2021/12/12