[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52380: ERT, buffers and windows (was: bug#52380: 28.0.50; [PATCH] ru
From: |
Kévin Le Gouguec |
Subject: |
bug#52380: ERT, buffers and windows (was: bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter) |
Date: |
Fri, 10 Dec 2021 21:09:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>
>>> Makes sense to me; pushed to emacs-28.
>>
>> But then I reverted it, because it led to a test failure, so could you
>> have a look at that?
>
> Well great; I meant to write a test case for that eventually.
>
> Assuming you mean python-tests--bug31398? That's the one I'm seeing
> failing with my patch.
>
> I've banged my head on it for an hour now; I don't understand what's
> going on. The test case is checking precisely what I was trying to fix,
> and for some reason the set-buffer I removed does something that the
> pop-to-buffer I replaced it with doesn't.
>
> What set-buffer does not, of course, is actually work in interactive
> usage 😒
If I amend the test as follows:
diff --git a/test/lisp/progmodes/python-tests.el
b/test/lisp/progmodes/python-tests.el
index 15bda5c197..783f115fc7 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -5454,6 +5454,7 @@ python-tests--bug31398
"Test for https://debbugs.gnu.org/31398 ."
(skip-unless (executable-find python-tests-shell-interpreter))
(let ((buffer (process-buffer (run-python nil nil 'show))))
+ (should (eq (get-buffer-window buffer) (selected-window)))
(should (eq buffer (current-buffer)))
(pop-to-buffer (other-buffer))
(run-python nil nil 'show)
… then (should (eq (get-buffer-window buffer) (selected-window)))
passes, but (should (eq buffer (current-buffer))) does not. Does that
make sense to anyone?
- bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter, Kévin Le Gouguec, 2021/12/08
- bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter, Lars Ingebrigtsen, 2021/12/10
- bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter, Lars Ingebrigtsen, 2021/12/10
- bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter, Kévin Le Gouguec, 2021/12/10
- bug#52380: ERT, buffers and windows (was: bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter),
Kévin Le Gouguec <=
- bug#52380: ERT, buffers and windows (was: bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter), Eli Zaretskii, 2021/12/10
- bug#52380: ERT, buffers and windows, Kévin Le Gouguec, 2021/12/10
- bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter, Kévin Le Gouguec, 2021/12/11
- bug#52380: 28.0.50; [PATCH] run-python no longer focuses interpreter, Lars Ingebrigtsen, 2021/12/12
- bug#52380: 28.0.50; [PATCH v2] run-python no longer focuses interpreter, Kévin Le Gouguec, 2021/12/12
- bug#52380: 28.0.50; [PATCH v2] run-python no longer focuses interpreter, Lars Ingebrigtsen, 2021/12/12