bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#52158: 29.0.50; Add key binding fo vc-git-stash


From: Robert Pluim
Subject: bug#52158: 29.0.50; Add key binding fo vc-git-stash
Date: Mon, 06 Dec 2021 09:58:24 +0100

>>>>> On Mon, 6 Dec 2021 07:32:33 +0100, Manuel Uberti 
>>>>> <manuel.uberti@inventati.org> said:

    Manuel> On 06/12/21 07:31, Lars Ingebrigtsen wrote:
    >> Manuel Uberti <manuel.uberti@inventati.org> writes:
    >> 
    >>> Thank you for this. May I suggest to add 'z p' bound to
    >>> vc-git-stash-pop to vc-dir-git-mode-map?
    >> But that command pops the stash under point, so you have to move
    >> point
    >> to a stash line first.  So it doesn't seem very helpful to have in the
    >> minor mode map.
    >> 

    Manuel> I thought vc-git-stash-pop-at-point did that.

It does, and thatʼs the one bound to 'P' in the stash area
keymap. 'pop' is destructive, so I think it should be bound only when
youʼre actually looking at the stash list (unlike the new 'z c' and 'z
s' bindings).

BTW, the stash area bindings are all upper case, and the new ones are
lower case. Can we make them more consistent?

Robert
-- 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]