|
From: | Dmitry Gutov |
Subject: | bug#52172: Fix vc-git--program-version to support Git for macOS version string |
Date: | Mon, 6 Dec 2021 03:57:00 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
Hi Lars! On 29.11.2021 17:47, Lars Ingebrigtsen wrote:
Justin Schell<justinmschell@gmail.com> writes:`topic.fix-vc-git--program-version.ignore-trailing.patch` updates the regexp used to match numeric version strings that are a combination of digits and dots (starting with a digit), ignoring anything else that comes after. Any trailing dots are then stripped. This is more general than the current approach of supporting a numeric version string only,I think this approach makes the most sense, but perhaps Dmitry has an opinion here (added to the CCs).
Looks good to me (especially with included tests). The trailing-dot-stripping approach, that is.
I would even suggest to try to get it into emacs-28 (given that apparently that functionality has been broken in macOS for a long time).
But then again, if it's only been reported now, maybe it's not hugely important and Emacs 28 can live without it.
[Prev in Thread] | Current Thread | [Next in Thread] |