bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separato


From: Juri Linkov
Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus
Date: Sun, 05 Dec 2021 19:59:22 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)

>  (defun help-mode-context-menu (menu click)
>    "Populate MENU with Help mode commands at CLICK."
> -  (define-key menu [help-mode-separator] menu-bar-separator)
> +  (define-key-after menu [help-mode-separator] menu-bar-separator
> +    'top-separator)

Now I realized that it's possible to do the same without 'top-separator':

  (define-key-after menu [help-mode-separator] menu-bar-separator
    "Context Menu")

Or when the title string is defined as a variable:

  (defvar context-menu-title "Context Menu")

  (define-key-after menu [help-mode-separator] menu-bar-separator
    context-menu-title)

But maybe 'top-separator' still could be used for clarity?
Or it increases complexity?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]