bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode


From: Jim Porter
Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode
Date: Sat, 4 Dec 2021 14:09:50 -0800

On 12/4/2021 12:56 PM, Jim Porter wrote:
On 12/4/2021 11:50 AM, Juri Linkov wrote:
`context-menu-middle-separator' is a function, so it requires the
`context-menu-' prefix.  It adds the menu item [middle-separator].
Since "middle" is an adjective, the word order can't be "separator-middle".
But "buffers-separator" doesn't look nicer than `separator-buffers'.

I think `FOO-separator' is the best choice here for the separators themselves. `FOO' acts as a noun adjunct[1], modifying the underlying object: a separator. For functions that just make a separator, they'd be named `MODULE-[FOO-]-separator', with `FOO-' being optional if it would be redundant with the module name. So then `context-menu-middle-separator' is the right function name, and it adds a separator named `middle-separator'.

`buffers-separator' is a bit of an odd phrasing since, as the Wikipedia article mentions, "Noun adjuncts were traditionally mostly singular". However, I think it's still a bit easier to read that correctly as "the separator used to mark the buffers", whereas `separator-buffers' reads more like "buffers used to separate things" to me.

Since this should just be a trivial renaming, hopefully we can merge that into Emacs 28 so we're not locked into the current names.

[1] https://en.wikipedia.org/wiki/Noun_adjunct

Ok, filed bug#52286 for this: https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg00327.html





reply via email to

[Prev in Thread] Current Thread [Next in Thread]