[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51296: [PATCH] Add WebP format support
From: |
Eli Zaretskii |
Subject: |
bug#51296: [PATCH] Add WebP format support |
Date: |
Thu, 21 Oct 2021 21:39:55 +0300 |
> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 21 Oct 2021 11:36:45 -0700
> Cc: 51296@debbugs.gnu.org
>
> >> + contents = (uint8_t*) SSDATA (specified_data);
> >
> > Space before '*' again. Also, is the type cast really needed? If
> > not, it is better to drop it.
>
> Fixed the style issue.
>
> The cast fixes this warning, so I kept it and added a comment saying
> "Casting avoids a GCC warning":
>
> image.c: In function ‘webp_load’:
> image.c:8878:16: warning: pointer targets in assignment from ‘char *’
> to ‘uint8_t *’ {aka ‘unsigned char *’} differ in signedness
> [-Wpointer-sign]
> 8878 | contents = SSDATA (specified_data);
> | ^
And if you use SDATA instead of SSDATA?
Otherwise, I think this is good to go, thanks.
- bug#51296: [PATCH] Add WebP format support, (continued)
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/20
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/21
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/21
- bug#51296: [PATCH] Add WebP format support,
Eli Zaretskii <=
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/21
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/22
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/22
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/22
- bug#51296: [PATCH] Add WebP format support, Eli Zaretskii, 2021/10/22
- bug#51296: [PATCH] Add WebP format support, Stefan Kangas, 2021/10/22