[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51176: eww switch buffer by title
From: |
Protesilaos Stavrou |
Subject: |
bug#51176: eww switch buffer by title |
Date: |
Fri, 15 Oct 2021 14:22:27 +0300 |
User-agent: |
Notmuch/0.33.2 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
On 2021-10-15, 12:35 +0200, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> Please find attached the patch which implements a renaming scheme for
>> EWW buffers. I include Abhiseck, the co-author of this patch, in Cc.
>>
>> What do you think?
>>
>> We had entertained the notion of a single defcustom with more options,
>> but ultimately decided against it on the grounds that it was more
>> complex.
>
> Yeah, looks good to me, but:
>
> miha@kamnitnik.top writes:
>
>> With your patch, the buffer isn't renamed if the user presses "l" or "r"
>> to go backward and forward in history. I suggest calling your rename
>> function from 'eww-update-header-line-format' instead.
>
> Yes, it has to be performed upon all updates. But putting it in that
> function would be misleading, so what about creating a new function
> `eww--after-page-change' that would call 'eww-update-header-line-format'
> and
>
> (when eww-auto-rename-buffer-flag
> (funcall eww-auto-rename-buffer-function))
>
> and call that where 'eww-update-header-line-format' is called now.
>
> And we don't really call user options -flag, so rename it to just
> `eww-auto-rename-buffer'.
Thanks for the feedback! Please find attached the revised patch, based
on what you suggested:
0001-Implement-auto-renaming-scheme-for-EWW-buffers-simple.patch
Because it may be useful for your consideration, there also exists the
more complex approach that I alluded to earlier ("complex" may be an
exaggeration, but still). Attached as well and also based on your
feedback.
0001-Implement-auto-renaming-scheme-for-EWW-buffers-complex.patch
--
Protesilaos Stavrou
https://protesilaos.com
0001-Implement-auto-renaming-scheme-for-EWW-buffers-complex.patch
Description: Text Data
0001-Implement-auto-renaming-scheme-for-EWW-buffers-simple.patch
Description: Text Data
- bug#51176: eww switch buffer by title, (continued)
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/13
- bug#51176: eww switch buffer by title, Juri Linkov, 2021/10/13
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/13
- bug#51176: eww switch buffer by title, Juri Linkov, 2021/10/13
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/13
- bug#51176: eww switch buffer by title, Protesilaos Stavrou, 2021/10/13
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/13
- bug#51176: eww switch buffer by title, Protesilaos Stavrou, 2021/10/15
- bug#51176: eww switch buffer by title, miha, 2021/10/15
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/15
- bug#51176: eww switch buffer by title,
Protesilaos Stavrou <=
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/15
- bug#51176: eww switch buffer by title, Jose Antonio Ortega Ruiz, 2021/10/15
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/15
- bug#51176: eww switch buffer by title, Jose Antonio Ortega Ruiz, 2021/10/15
- bug#51176: eww switch buffer by title, Protesilaos Stavrou, 2021/10/16
- bug#51176: eww switch buffer by title, Protesilaos Stavrou, 2021/10/16
- bug#51176: eww switch buffer by title, Jose Antonio Ortega Ruiz, 2021/10/16
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/18
- bug#51176: eww switch buffer by title, Protesilaos Stavrou, 2021/10/18
- bug#51176: eww switch buffer by title, Lars Ingebrigtsen, 2021/10/18