[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48153: 28.0.50; minor mode keymaps should not override keymap given
From: |
Stefan Monnier |
Subject: |
bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer |
Date: |
Wed, 05 May 2021 10:17:58 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> 1. On emacs 27, minor mode keybindings will only override the key
> bindings given to read-from-minibuffer after the second invocation of
> the minibuffer, but doesn't on the first invocation.
Something like that, yes.
That's only for minor modes defined via `define-globalized-minor-mode`.
Not for global minor modes defined in the usual way via (define-minor-mode
... :global t ...).
This change makes for a more predictable behavior and is a side-effect
of the change described in etc/NEWS as:
** An active minibuffer now has major mode 'minibuffer-mode', not the
erroneous 'minibuffer-inactive-mode' it formerly had.
More specifically, the difference is that in Emacs<28 sometimes those
globalized minor modes where not enabled (hence their keybindings are
not active).
> 2. On emacs 28, minor mode keybindings override the key bindings given
> to read-from-minibuffer at all times.
And this was also true in all previous versions of Emacs.
> 3. But, `minor-mode-overriding-map-alist` does not override the
> override in effect in the minibuffer like other buffers.
That's the part of your bug report I haven't understood yet.
> My expectation is when a keymap is explicitly given to
> read-from-minibuffer, the key bindings in it should take precedence,
> but it doesn't.
No, this keymap is the "local map" a.k.a "major mode map", so it has
lower precedence than minor keymaps. Always had.
> As you can see from the snippet from my last email, both
> ido-completion-map and test-mode bind to C-k, I expect the C-k binding
> in ido-completion-map to take effect inside the minibuffer, without
> being overridden by any minor modes in effect inside the minibuffer.
This expectation is incorrect ;-)
> If this is not to be desired, I'd expect setting
> minor-mode-overriding-map-alist or the usual key binding lookup search
> algorithm to work inside the minibuffer.
This should be the case: minibuffers are treated exactly like all other
buffers by the keymap code, AFAIK.
Stefan
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, (continued)
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Gregory Heytings, 2021/05/04
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Gregory Heytings, 2021/05/04
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Jimmy Yuen Ho Wong, 2021/05/04
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Gregory Heytings, 2021/05/04
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Jimmy Yuen Ho Wong, 2021/05/04
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Gregory Heytings, 2021/05/05
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Jimmy Yuen Ho Wong, 2021/05/05
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Eli Zaretskii, 2021/05/05
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Gregory Heytings, 2021/05/05
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Jimmy Yuen Ho Wong, 2021/05/05
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer,
Stefan Monnier <=
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Jimmy Yuen Ho Wong, 2021/05/06
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Stefan Monnier, 2021/05/09
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Gregory Heytings, 2021/05/05
- bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer, Stefan Monnier, 2021/05/05