[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29541: 27.0.50; Use generic function when restoring eieio-persistent
From: |
Eric Abrahamsen |
Subject: |
bug#29541: 27.0.50; Use generic function when restoring eieio-persistent, remove validation |
Date: |
Thu, 27 Aug 2020 18:40:11 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>>> 1. `object-write' is already a method. That means the writing process
>>> can be overridden and customized, but the reading process can't, which
>>> removes most of the benefit of being able to override the write. This
>>> would allow "matching" methods for writing and reading.
>>
>> This makes sense, and having a method instead of a function here
>> certainly seems cleaner...
>>
>> Did anybody with a deeper knowledge of the eieio machinery provide any
>> feedback? It's a quite large patch...
>
> There wasn't any feedback here, so I think that you should go ahead and
> apply the patch, Eric. I think it makes sense conceptually, at least.
This was quite a while ago, and the original patch no longer applies.
I've done up the same changes as two separate patches: one removing
extra validation, and the other creating a generic function for
constructing eieio-persistent objects. All the tests pass.
0002-New-eieio-persistent-make-instance-generic-function.patch
Description: Text Data
0001-Remove-redundant-slot-validation-in-eieio-persistent.patch
Description: Text Data