bug#33118: Emacs for macOS Crash and Font Issue

[Alan Third]

On Sun, Aug 16, 2020 at 07:52:08PM +0200, Lars Ingebrigtsen wrote:
> Alan Third <alan@idiocy.org> writes:
> 
> >> When used in full screen mode, entering “C-x 5 2” creates a new window
> >> (correctly except with the wrong typeface), but closing that window
> >> crashes Emacs every time.
> >
> > This is a known issue that’s fixed in Emacs 26, however it depends on
> > how it’s been built.
> >
> > Given that it keeps rearing its ugly head, I’m inclined to remove the
> > compile‐time check and just leave the run‐time check.
> 
> It's unclear whether this means that the bug has been fixed or not?

No, it's not. The "fix" would be:

modified   src/nsterm.m
@@ -7669,13 +7669,8 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f
   /* macOS Sierra automatically enables tabbed windows.  We can't
      allow this to be enabled until it's available on a Free system.
      Currently it only happens by accident and is buggy anyway.  */
-#if defined (NS_IMPL_COCOA) \
-  && MAC_OS_X_VERSION_MAX_ALLOWED >= 101200
-#if MAC_OS_X_VERSION_MIN_REQUIRED < 101200
   if ([win respondsToSelector: @selector(setTabbingMode:)])
-#endif
     [win setTabbingMode: NSWindowTabbingModeDisallowed];
-#endif
 
   ns_window_num++;
   return self;

however that will introduce a warning into builds on old versions of macOS.

The correct solution would be for people making builds for others to
read "Targeting different macOS versions" in the nextstep/INSTALL
file, but perhaps that's too much to ask.
-- 
Alan Third