[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21652: bell chars
From: |
Stefan Kangas |
Subject: |
bug#21652: bell chars |
Date: |
Fri, 14 Aug 2020 23:26:13 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Tom Baker <tombaker17@gmail.com> writes:
> I have a real need to have my command shells beep at me when their work is
> done, so I set it up so beeps are passed to the
> host system.
>
> In the function comint-carriage-motion I alter
>
> (defun comint-carriage-motion (start end)
> "Interpret carriage control characters in the region from START to END.
> Translate carriage return/linefeed sequences to linefeeds.
> Make single carriage returns delete to the beginning of the line.
> Make backspaces delete the previous character."
>
> to say
>
> (defun comint-carriage-motion (start end)
> "Interpret carriage control characters and bells in the region from START
> to END.
> Translate carriage return/linefeed sequences to linefeeds.
> Make single carriage returns delete to the beginning of the line.
> Make backspaces delete the previous character. Pass bells through."
>
> and the code chunk
>
> (cond ((= ch ?\b) ; CH = BS
> (delete-char 1)
> (if (> (point) lbeg)
> (delete-char -1)))
> ((= ch ?\n)
> (when delete-end ; CH = LF
> (if (< delete-end (point))
> (delete-region lbeg delete-end))
> (set-marker delete-end nil)
> (setq delete-end nil))
> (forward-char 1)
> (setq lbeg (point)))
> (t ; CH = CR
>
> changed to
>
> (cond ((= ch ?\b) ; CH = BS
> (delete-char 1)
> (if (> (point) lbeg)
> (delete-char -1)))
> ((= ch ?\n)
> (when delete-end ; CH = LF
> (if (< delete-end (point))
> (delete-region lbeg delete-end))
> (set-marker delete-end nil)
> (setq delete-end nil))
> (forward-char 1)
> (setq lbeg (point)))
> ((= ch ?\a)
> (forward-char 1)
> (ding)
> (sit-for 0.45 t)) ; CH = BL
> (t ; CH = CR
So the difference here is that you would like to add a call to (ding)?
I'm not sure the addition you propose is suitable for general use.
Perhaps you could explain the use-case here in a bit more detail? For
example, why can't you just add an advice to the function in question?
Best regards,
Stefan Kangas
- bug#21652: bell chars,
Stefan Kangas <=
- bug#21652: bell chars, Tom Baker, 2020/08/15
- bug#21652: bell chars, Stefan Kangas, 2020/08/16
- bug#21652: bell chars, Eli Zaretskii, 2020/08/16
- bug#21652: bell chars, Tom Baker, 2020/08/16
- bug#21652: bell chars, Eli Zaretskii, 2020/08/16
- bug#21652: bell chars, Andreas Schwab, 2020/08/16