[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42801: 26.3; customize-apropos shows bogus State buttons after savin
From: |
Lars Ingebrigtsen |
Subject: |
bug#42801: 26.3; customize-apropos shows bogus State buttons after saving |
Date: |
Fri, 14 Aug 2020 16:41:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Mauro Aranda <maurooaranda@gmail.com> writes:
> I can reproduce this bug in Emacs 26.3. On current master, the bug manifests
> differently: we don't get the State buttons, but we do get the message:
> Symbol's function definition is void: nil
>
> The difference lies in `custom-variable-modified-p' bugging out before we draw
> the bogus State buttons for all options, because it is not supposed to handle
> hidden widgets.
>
> The bug is that Custom-save recalculates the state and redraws all widgets,
> even the hidden ones. I propose the attached patch, that changes
> Custom-save to only act on edited widgets in the buffer.
Thanks; applied to Emacs 28.1.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no