[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38294: [PATCH] Handle killing of virtual buffers in Ido
From: |
Lars Ingebrigtsen |
Subject: |
bug#38294: [PATCH] Handle killing of virtual buffers in Ido |
Date: |
Fri, 14 Aug 2020 13:00:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:
> Hi Stefan,
>
>> Killing it isn't a no-op though. When you kill it, you get prompted to
>> save changes, it runs hooks in the background, presumably removes it
>> from active memory, other functions will no longer be able to just
>> switch to it, etc., etc.
Yeah, but these "virtual buffers" don't really exist, so none of that
will happen, I'd have thought?
> Point taken. In that case, my only complaint would be that
> ‘ido-kill-buffer-at-head’ does treat killing a virtual buffer as
> removing it from ‘recentf-list’ (just as suggested here), so there is
> some inconsistency. However, I can live with it.
Yeah, that is inconsistent:
;;; KILL CURRENT BUFFER
(defun ido-kill-buffer-at-head ()
"Kill the buffer at the head of `ido-matches'.
If cursor is not at the end of the user input, delete to end of input."
[...]
;; Handle virtual buffers
((assoc buf ido-virtual-buffers)
(setq recentf-list
(delete (cdr (assoc buf ido-virtual-buffers)) recentf-list))
So now I'm kinda thinking that your original patch is correct. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Lars Ingebrigtsen, 2020/08/09
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Stefan Kangas, 2020/08/12
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Dario Gjorgjevski, 2020/08/13
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Stefan Kangas, 2020/08/13
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Dario Gjorgjevski, 2020/08/14
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido,
Lars Ingebrigtsen <=
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Stefan Kangas, 2020/08/14
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Dario Gjorgjevski, 2020/08/14
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Stefan Kangas, 2020/08/14
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Dario Gjorgjevski, 2020/08/15
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Lars Ingebrigtsen, 2020/08/15
- bug#38294: [PATCH] Handle killing of virtual buffers in Ido, Stefan Kangas, 2020/08/15