[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40863: [PATCH] Improve the display-time-world UI
From: |
Stefan Kangas |
Subject: |
bug#40863: [PATCH] Improve the display-time-world UI |
Date: |
Sun, 9 Aug 2020 15:11:06 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
>> (define-derived-mode display-time-world-mode special-mode "World clock"
>> "Major mode for buffer that displays times in various time zones.
>> See `display-time-world'."
>> + (setq revert-buffer-function 'display-time-world-timer)
> ^
> Nit: #'
>
> More importantly, doesn't revert-buffer-function need two parameters?
Fixed.
>> Subject: [PATCH 3/3] Rearrange and clean up code in time.el (Bug#40863)
>>
>> * lisp/time.el (world-clock, zoneinfo-style-world-list)
>> (legacy-style-world-list, world-clock-list)
>> (time--display-world-list, world-clock-time-format)
>> (world-clock-timer-enable, world-clock-timer-second): Move definitions
>> closer to 'world-clock' code.
>
> Unless I'm misreading it, the patch you attached seems to be adding
> duplicate definitions rather than moving them.
Uhm, right... Fixed in the attached.
Thanks again for the review.
Best regards,
Stefan Kangas
0001-Improve-display-time-world-UI-Bug-40863.patch
Description: Text Data
0002-Rename-display-time-world-to-world-clock-Bug-40863.patch
Description: Text Data
0003-Rearrange-and-clean-up-code-in-time.el-Bug-40863.patch
Description: Text Data