[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42272: 27.0.91; [PATCH] Fix doc-view rescale
From: |
Lars Ingebrigtsen |
Subject: |
bug#42272: 27.0.91; [PATCH] Fix doc-view rescale |
Date: |
Wed, 05 Aug 2020 17:13:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
"Fu, Yuan" <ykf5041@psu.edu> writes:
> In Emacs 27, doc-view doesn’t to image rescaling if imagemagick is not
> present. However, since we have native image rescaling now, we want
> to rescale regardless of imagemagick. I also added convenient
> centering commands to doc-view.el. Note that the patch is made on
> Emacs master branch.
The imagemagick fixes look good to me, and the new functionality, too.
But this should probably be done in two separate patches, and the patch
with the new functionality also needs to be documented in the Document
View node in the misc.texi manual. (And it also needs an etc/NEWS
entry.)
Can you do the patch splitting and documentation additions and resubmit?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale,
Lars Ingebrigtsen <=
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale, Yuan Fu, 2020/08/06
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale, Lars Ingebrigtsen, 2020/08/07
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale, Fu, Yuan, 2020/08/13
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale, Lars Ingebrigtsen, 2020/08/14
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale, Yuan Fu, 2020/08/14
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale, Lars Ingebrigtsen, 2020/08/14
- bug#42272: 27.0.91; [PATCH] Fix doc-view rescale, Yuan Fu, 2020/08/14