|
From: | Juri Linkov |
Subject: | bug#39190: 28.0.50; two buffers with same buffer-file-name (diff-syntax-fontify-props) |
Date: | Wed, 29 Jan 2020 00:53:27 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.0.60 (x86_64-pc-linux-gnu) |
>> it can cause >> problems because hooks are run during this time (e.g. major mode hooks) >> which may take action under the mistaken assumption that this buffer >> really correspond to the file > > I think diff-mode could also use delay-mode-hooks and then run them (or > not) outside of that let binding. Interesting idea, I see no problem with this: diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el index 2dbab80208..9035f7643a 100644 --- a/lisp/vc/diff-mode.el +++ b/lisp/vc/diff-mode.el @@ -2719,7 +2719,7 @@ diff-syntax-fontify-props (cl-assert (null buffer-file-name)) (let ((enable-local-variables :safe) ;; to find `mode:' (buffer-file-name file)) - (set-auto-mode) + (delay-mode-hooks (set-auto-mode)) ;; FIXME: Is this really worth the trouble? (when (and (fboundp 'generic-mode-find-file-hook) (memq #'generic-mode-find-file-hook
[Prev in Thread] | Current Thread | [Next in Thread] |