bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep


From: Dmitry Gutov
Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
Date: Fri, 24 Jan 2020 17:31:20 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 24.01.2020 17:11, Stefan Monnier wrote:
It's arguably breaking compatibility.  But you might be right that maybe
it's a non issue.  A quick `grep` shows that outside Emacs itself, at
least Helm might be affected.

I don't disagree. But I'm not sure how to keep the backward compatibility either.

Unless the old variable is kept as-is (both assigned and referred to) and the new one is looked up solely in one place (minibuffer-force-complete-and-exit). This way, we can't mark the old one as obsolete, though.

(BTW, at least one reference to minibuffer-completion-confirm in Emacs binds it to t already; not sure what's the intended effect: lisp/calc/calc-store.el:197).

I think this is a typo for `minibuffer-completion-confirm`, right?

Ummm, yes.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]