[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29842: 27.0; `dired-change-marks': args should not be optional
From: |
Stefan Kangas |
Subject: |
bug#29842: 27.0; `dired-change-marks': args should not be optional |
Date: |
Sun, 19 Jan 2020 16:02:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
close 29842 28.1
thanks
Drew Adams <drew.adams@oracle.com> writes:
> Furthermore, the code should perhaps not just call
> `ding' if you hit RET. Instead of this:
>
> (if (or (eq old ?\r) (eq new ?\r))
> (ding)
> ...)
>
> it should perhaps do something like this:
>
> (unless (char-displayable-p old)
> (error "Not a displayable character: `%c'" old))
> (unless (char-displayable-p new)
> (error "Not a displayable character: `%c'" new))
>
> The current code predates the existence of
> `char-displayable-p'.
>
> (Yes, that's a different bug, but perhaps it can be
> taken care of in the context of this report. If not,
> don't worry about it.)
Fixed on master in commit e5e31aab9b.
Best regards,
Stefan Kangas