[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
From: |
Dmitry Gutov |
Subject: |
bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep |
Date: |
Sat, 18 Jan 2020 04:38:07 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 11.01.2020 21:59, João Távora wrote:
rs due to fundamental changes in the problem others due
to opinion. It "feels" nice for me now, but if you can come up with a better
binding for RET, shoot it over, I'll tell you what I think about it. I think
you'll find it will have advantages and disadvantages. But who knows:-)
Without going far into changing its behavior, I think we have two
options for this now. Since the only occurrence of "Incomplete" of
minibuffer.el is in minibuffer-force-complete-and-exit, apparently one
issue is that the glob input doesn't succeed the test-completion test in
the read-file-name-internal completion table used by grep-read-files.
So the options are:
1. Make sure that the table says globs are valid input (by adding a
wrapper, probably). This should make RET silently accept the input in
this case. This is a good way to proceed if we're reasonably confident
we can deal with similar issues in the same way, and there won't be too
many of them.
2. Make icomplete-force-complete-and-exit show a different message, so
that the user knows what to do. Instead of just "Incomplete", add
something like ", press \\[exit-minibuffer\\] to accept".
Maybe do both.
The second option can look like this:
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index a1a67e2330..d88ebca15d 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -185,7 +185,15 @@ icomplete-force-complete-and-exit
;; calculated, This causes the first cached completion to
;; be taken (i.e. the one that the user sees highlighted)
completion-all-sorted-completions)
- (minibuffer-force-complete-and-exit)
+ (progn
+ (unless completion-cycling
+ (minibuffer-force-complete nil nil 'dont-cycle))
+ (completion--complete-and-exit
+ (minibuffer-prompt-end) (point-max) #'exit-minibuffer
+ ;; If the previous completion completed to an element which fails
+ ;; test-completion, then we shouldn't exit, but that should be
rare.
+ (lambda () (minibuffer-message "Incomplete, press %s to accept"
+ (substitute-command-keys
"\\[exit-minibuffer]")))))
;; Otherwise take the faster route...
(minibuffer-complete-and-exit)))
(Or we can put the message into a global var which
icomplete-force-complete-and-exit would bind to this message string).
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, waah, 2020/01/06
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/08
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/09
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, waah, 2020/01/09
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/09
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/09
- Message not available
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/09
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/10
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, waah, 2020/01/10
- Message not available
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/11
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep,
Dmitry Gutov <=
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/19
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Stefan Monnier, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/21
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/23
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/24
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Stefan Monnier, 2020/01/21