[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple arti
From: |
Eric Abrahamsen |
Subject: |
bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article |
Date: |
Mon, 13 Jan 2020 13:49:59 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Pankaj Jangid <p4j@j4d.net> writes:
>
>> New command 'S A' ('gnus-summary-attach-article') is not working
>> properly with multiple articles.
>>
>> * Steps
>> 1. Select multiple articles in summary buffer using process mark '#'
>> 2. 'S A'
>> 3. Creates a new message buffer with multiple articles attached. BUT all
>> the articles are same. The latest among the selected articles is
>> repeated multiple times.
>
> That command sets up the message-mode buffer and makes it current before
> iterating over the articles, so it's unable to actually find the
> articles and simply repeats the last value of
> gnus-original-article-buffer.
Okay, that was only right by accident. The real problem was that the
code inside the iterate was setting the buffer to the message-mode
buffer. Then the calls to `gnus-summary-select-article' kept re-setting
to the summary-buffer, but always on the same article.
Anyway, would you test this patch and confirm it fixes the problem?
Eric
attach-article-fix.diff
Description: Text Data
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Pankaj Jangid, 2020/01/13
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eric Abrahamsen, 2020/01/13
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article,
Eric Abrahamsen <=
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Pankaj Jangid, 2020/01/13
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eric Abrahamsen, 2020/01/18
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Pankaj Jangid, 2020/01/18
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eric Abrahamsen, 2020/01/18
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eli Zaretskii, 2020/01/18
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eric Abrahamsen, 2020/01/18
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eric Abrahamsen, 2020/01/18
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eli Zaretskii, 2020/01/18
- bug#39112: 27.0.60; gnus-summary-attach-article 'S A' with multiple articles selected repeats latest article, Eric Abrahamsen, 2020/01/18