[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nic
From: |
Amin Bandali |
Subject: |
bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens) |
Date: |
Mon, 18 Nov 2019 10:49:24 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Here’s a patch that fixes the issue for me:
>From 10f1fb7ccfb3e76dbd5df44f3f0e2780d24ba99b Mon Sep 17 00:00:00 2001
From: Amin Bandali <bandali@gnu.org>
Date: Mon, 18 Nov 2019 10:24:48 -0500
Subject: [PATCH] Fix ERC not matching nicks surrounded parens (bug#38257)
* lisp/erc/erc-{button,match}.el (erc-{button,match}-syntax-table):
Omit parens, as they're not valid nick characters, per RFC 2812
section 2.3.1.
---
lisp/erc/erc-button.el | 2 --
lisp/erc/erc-match.el | 2 --
2 files changed, 4 deletions(-)
diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el
index ec70260146..3dc4e92a46 100644
--- a/lisp/erc/erc-button.el
+++ b/lisp/erc/erc-button.el
@@ -223,8 +223,6 @@ erc-button-keymap
(defvar erc-button-syntax-table
(let ((table (make-syntax-table)))
- (modify-syntax-entry ?\( "w" table)
- (modify-syntax-entry ?\) "w" table)
(modify-syntax-entry ?\[ "w" table)
(modify-syntax-entry ?\] "w" table)
(modify-syntax-entry ?\{ "w" table)
diff --git a/lisp/erc/erc-match.el b/lisp/erc/erc-match.el
index e9ed735516..e87076dbe3 100644
--- a/lisp/erc/erc-match.el
+++ b/lisp/erc/erc-match.el
@@ -246,8 +246,6 @@ erc-match-exclude-server-buffer
;; just put it in erc.el
(defvar erc-match-syntax-table
(let ((table (make-syntax-table)))
- (modify-syntax-entry ?\( "w" table)
- (modify-syntax-entry ?\) "w" table)
(modify-syntax-entry ?\[ "w" table)
(modify-syntax-entry ?\] "w" table)
(modify-syntax-entry ?\{ "w" table)
--
2.23.0
- bug#38257: 27.0.50; ERC does not match or highlight nick surrounded by parens, Amin Bandali, 2019/11/18
- Message not available
- bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens),
Amin Bandali <=
- bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens), Amin Bandali, 2019/11/20
- bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens), Lars Ingebrigtsen, 2019/11/21
- bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens), Amin Bandali, 2019/11/21
- bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens), Lars Ingebrigtsen, 2019/11/22
- bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens), Lars Ingebrigtsen, 2019/11/22
- bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens), Amin Bandali, 2019/11/22
bug#38257: Missed notif > broken buttons, Corwin Brust, 2019/11/21