[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters
From: |
Kévin Le Gouguec |
Subject: |
bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters |
Date: |
Thu, 14 Nov 2019 08:02:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Thanks for your input Juri. I see that your work on
read-char-from-minibuffer has been pushed to master; I'll start working
on a v6 using that function instead of read-multiple-choice ASAP.
Juri Linkov <juri@linkov.net> writes:
> Please use a shorter prompt like
>
> 1 occurrence of ‘?’ will not be substituted. Proceed? (y, n or ?)
Will do.
> In the new "Dired help" buffer where there is enough space to add
> the command line with '^' markers.
Note that the current implementation is quite naive: it falls apart if
the command is wider than the help window. E.g.:
some-command "first?argument" "sec⤸
⤹ond?argument" "final-argument"
^ ⤸
⤹ ^
(⤸ and ⤹ represent fringe indicators for wrapped lines.)
I don't know how important it is to handle this situation, since
read-char-from-minibuffer allows C-x o'ing to the help buffer and
toggling truncated lines.
>> - Preventing '`' being linked to the backquote macro in the docstring
>> for dired-do-shell-command: still no idea how to fix that, but that
>> can be investigated independently.
>
> Maybe use double quotes "`" as an exception.
Maybe. The docstring single-quotes every other character it mentions
though (?, *, &, ;), so that would look sort of inconsistent.
Note that this problem also impacts other docstrings[1].
>> - The details window might not be tall enough, in which case maybe I
>> should add [f]orward-/[b]ackward-page actions like nsm.el does.
>
> Yesterday I added new keybindings C-v/M-v for scrolling the original
> window from the minibuffer.
Nice!
(Out of curiosity, would it make sense to also bind C-x < and C-x >?)
>> - UI bikeshedding: maybe drop the leading "Warning:"
>
> Right, this makes the prompt shorter.
Will do then.
Again, thank you for your time.
[1]
subr.el:372:like `%', `\\=`' and `\\='', use (error \"%s\" MESSAGE).
subr.el:388:like `%', `\\=`' and `\\='', use (error \"%s\" MESSAGE).
emulation/viper-util.el:1173:symbols like `\\=`', `\\='', `:', `\"', `)', and
`{' are excluded.
leim/quail/cyrillic.el:1362:`]', `\\', `\\=`' and `[' keys respectively, Caps
Lock does not affect them."
leim/quail/hebrew.el:116: `\\=`' is used to switch levels instead of Alt-Gr.
leim/quail/hebrew.el:606: `\\=`' is used to switch levels instead of Alt-Gr.
leim/quail/thai.el:50: `ฃ' and `ฅ' are assigned to `\\=`' and `~'
respectively,
Note also that there are places where this works as intended:
emacs-lisp/backquote.el:253: "See `\\=`' (also `pcase') for the usage of
`,'.")
emacs-lisp/backquote.el:257: "See `\\=`' for the usage of `,@'.")