|
From: | Dmitry Gutov |
Subject: | bug#35376: 26.2; (emacs) `Xref Commands' - no mention of `mouse-1' |
Date: | Tue, 30 Jul 2019 17:08:04 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 09.07.2019 17:13, Lars Ingebrigtsen wrote:
The mouse bindings are a bit confusing: (defvar xref--button-map (let ((map (make-sparse-keymap))) (define-key map [mouse-1] #'xref-goto-xref) (define-key map [mouse-2] #'xref--mouse-2) map)) Why is the command called xref--mouse-2? That's a very non-descriptive command name.
It's been that way from the beginning. You can rename it, I think, if you have a better name in mind.
And... don't these two really kinda do the same thing? mouse-1 sets the point first and then goes to the xref, and mouse-2 ... does the same, only in a different way?
Does the idea of "not switching windows" make sense to you?
[Prev in Thread] | Current Thread | [Next in Thread] |