bug#23488: 25.0.93; Modules: inconsistent return types for error reporting

[Lars Ingebrigtsen]

Philipp Stephani <p.stephani2@gmail.com> writes:

> Of the module environment functions, 'copy_string_contents' is
> inconsistent with all the other functions in that it returns a boolean
> to indicate success/failure.  All other functions only set the last
> error status, to be checked with non_local_exit_check etc.  This should
> be made consistent, e.g. my having copy_string_contents return void.

Is that possible to do at this late date?  It's part of the advertised
API, I think, and changing it sounds like it'd break modules.

> Furthermore, the comment for copy_string_contents is incorrect.  If
> BUFFER is NULL, it returns true, not false.

I see you've fixed this later...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no