bug#26089: 25.1; Faulty documentation for skeleton-end-newline

[Lars Ingebrigtsen]

David Casperson <casper@unbc.ca> writes:

> The documentation for skeleton-end-newline says:
>
> "...This just influences the way the default `skeleton-end-hook' behaves."
>
> but in fact skeleton-end-newline is used in
>       (or (eolp) (not skeleton-end-newline) (newline-and-indent))
> in the function `skeleton-insert’ OUTSIDE of skeleton-end-hook (which
> is, by default nil).
>
> To witness behaviour contrary to the documentation, run latex-mode and
> call M-x latex-insert-block itemize with the cursor at the beginning of
> a non empty line.  There will be a blank line after the \end{itemize}.
> This differs from previous emacs versions.

Looks like this was fixed for Emacs 26:

commit 88cdf14b37a7344bb266e94512485e3cc738c23d
Author: Noam Postavsky <npostavs@gmail.com>
Date:   Mon Dec 19 19:49:47 2016 -0500

    Improve skeleton docstrings
    
    * lisp/skeleton.el (skeleton-end-newline): Remove mention of
    `skeleton-end-hook', its default code was moved into `skeleton-insert'.
    (skeleton-insert): Mention `skeleton-end-newline' and move reference to
    `skeleton-end-hook' above the explanation of skeleton syntax.


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no