bug#36618: 26.2; Misnamed `*-hooks' variables

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> The following variable names end in `-hooks', instead of `-hook' or
> `-functions' (there may be more - just noticed these in one of my
> sessions):
>
> bookmark-exit-hooks                    (OBS)

As you say, there's nothing to be done about obsolete -hooks variables.

> delay-mode-hooks                       (Bool)

These bool variables have logical names -- they say whether to do
something or other about the hooks, so I don't think they should change
names.

> delayed-mode-hooks                     XXX

That's not really a -hook variable, but list of hook variables to run,
so it's fine:

(defvar-local delayed-mode-hooks nil
  "List of delayed mode hooks waiting to be run.")

> ediff-before-session-group-setup-hooks XXX

This is a variable that's never used, apparently?  I'll just mark it as
obsolete.

> recentf-used-hooks                     XXX

It's a list of hooks, not a hook, so has a correct name.

> unload-feature-special-hooks           (aliased)

Same.

Nothing to be done for the rest; closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no