bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#36486: [PATCH] Add tests for text-property-search to check prop-matc


From: Lars Ingebrigtsen
Subject: bug#36486: [PATCH] Add tests for text-property-search to check prop-match-value
Date: Fri, 12 Jul 2019 16:37:21 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Juri Linkov <juri@linkov.net> writes:

> -                      (not (equal val p-val))))))
> +                      (not (if (and (listp p-val) (not (listp val)))
> +                               (member val p-val)
> +                             (equal val p-val)))))))

No, that's not an acceptable change, I think -- this function is a
search primitive, not a DWIM thing.  There's an abundance of things that
can be stored in text properties, to be compared with any number of
predicates.  You're trying to special-case it to search for faces, for
some reason, and that's not what it's for.

If you want a function to search for faces, that's something you can
write (based on this function), but that's not what this function is for.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]