bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faste


From: Dmitry Gutov
Subject: bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster)
Date: Fri, 5 Jul 2019 16:44:59 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 05.07.2019 1:05, Juri Linkov wrote:

BTW, why vc-git-log-incoming and vc-git-log-outgoing are interactive?
It seems these functions are not intended to be used as commands:

Makes sense, thank you. Please install.

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index f62e108322..6a6036cf8a 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1048,7 +1050,6 @@ vc-git-print-log
                '("--")))))))
(defun vc-git-log-outgoing (buffer remote-location)
-  (interactive)
    (vc-setup-buffer buffer)
    (vc-git-command
     buffer 'async nil
@@ -1062,7 +1063,6 @@ vc-git-log-outgoing
           "..HEAD")))
(defun vc-git-log-incoming (buffer remote-location)
-  (interactive)
    (vc-setup-buffer buffer)
    (vc-git-command nil 0 nil "fetch")
    (vc-git-command







reply via email to

[Prev in Thread] Current Thread [Next in Thread]