[Bug-gnu-arch] Re: [bug #5443] file-revert command

[Dustin Sallings]

On Friday, Sep 26, 2003, at 14:38 US/Pacific, address@hidden  
wrote:

        This is ridiculous.  Why was this bug closed?

	If it's because it doesn't compile against the latest, that sounds  
like a collision.  It compiled just fine against 177 which I merged in  
on 2003/09/24 (two days ago).

	If it's because of the formatting conventions, let me know what indent  
options to use to repair it.

        If it's because of the parameter ordering, that's a very minor fix.

	The only reason it should be closed as invalid is if you don't believe  
the file-revert command should exist (and it would've been nice to say  
so).  If this is the case, I think it's short-sighted.  This is the  
most common operation I perform in my revision control systems outside  
of the usual checkin procedure.

> =================== BUG #5443: LATEST MODIFICATIONS ==================
> http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5443&group_id=4899
>
> Changes by: Tom Lord <address@hidden>
> Date: Fri 09/26/2003 at 14:38 (US/Pacific)
>
>             What     | Removed                   | Added
> ----------------------------------------------------------------------- 
> ----
>           Resolution | None                      | Invalid
>               Status | Open                      | Feedback
>
>
> ------------------ Additional Follow-up Comments  
> ----------------------------
> Doesn't compile when merged with the latest.
>
> Please try to respect the existing format conventions.
>
> Return parameters (as in arch_locate_file) go first in the list.
>
>
>
>
>
> =================== BUG #5443: FULL BUG SNAPSHOT ===================
>
>
> Submitted by: dsallings               Project: GNU arch -- a revision  
> control system
> Submitted on: Fri 09/19/2003 at 13:53
> Category:  tla                        Severity:  5 - Major
> Bug Group:  small feature idea        Resolution:  Invalid
> Status:  Feedback                     Release:   
> address@hidden/tla--devo--1.1--patch-170
> Fixed Release:  address@hidden/hacks--tladev--1.1Merge  
> Request?:  yes -- merge from my archive
> Your Archive Name:  address@hidden Archive Location:   
> http://bleu.west.spy.net/~dustin/arch/projects-public/
> Assigned to:  None
>
> Summary:  file-revert command
>
> Original Submission:  As of patch-4, the bare minimum required to  
> implement file-revert was done (against  
> address@hidden/tla--devo--1.1--patch-166).
>
> patch-6 includes a refactoring of file-find, file-diffs, and  
> file-revert to use a common function for locating the original version  
> of the file rather than reproducing the code.  This is not required to  
> integrate the fix, but I include it here because I feel it was  
> required to do this correctly.
>
> patch-7 (latest as of this submission) catches up to  
> address@hidden/tla--devo--1.1--patch-170
>
> Follow-up Comments
> *******************
>
> -------------------------------------------------------
> Date: Fri 09/26/2003 at 14:38       By: tomlord
> Doesn't compile when merged with the latest.
>
> Please try to respect the existing format conventions.
>
> Return parameters (as in arch_locate_file) go first in the list.
>
>
>
>
> CC list is empty
>
>
> No files currently attached
>
>
> For detailed info, follow this link:
> http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5443&group_id=4899
>
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.gnu.org/
--
Dustin Sallings
408.321.1409