bug-glpk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-glpk] [Fwd: Re: glpk prints warnings which lead to failing sagemath


From: Andrew Makhorin
Subject: [Bug-glpk] [Fwd: Re: glpk prints warnings which lead to failing sagemath tests]
Date: Fri, 02 Mar 2018 12:53:51 +0300

-------- Forwarded Message --------
From: Tobias Hansen <address@hidden>
To: Andrew Makhorin <address@hidden>
Cc: Sébastien Villemot <address@hidden>, address@hidden,
address@hidden
Subject: Re: glpk prints warnings which lead to failing sagemath tests
Date: Fri, 2 Mar 2018 10:33:14 +0100

On 03/01/2018 11:06 AM, Andrew Makhorin wrote:
>> Comments from the sage ticket https://trac.sagemath.org/ticket/24824#ticket
>>
>> Comment (by jdemeyer):
>>
>>  Replying to [comment:5 thansen]:
>>  > GLP_MSG_OFF is not a relevant option to disable terminal/stdout output.
>>
>>  It's not our goal to completely disable terminal output. We still want to
>>  see error messages for example.
> To fix the bug please replace lines 923-930 in glpk/src/draft/glpios03.c
>
> #if 1 /* 16/III-2016 */
>       if (((glp_iocp *)T->parm)->flip)
> #if 0 /* 20/I-2018 */
>          xprintf("WARNING: LONG-STEP DUAL SIMPLEX WILL BE USED\n");
> #else
>          xprintf("Long-step dual simplex will be used\n");
> #endif
> #endif
>
> with the following ones:
>
> #if 1 /* 01/III-2018 */
>       if (((glp_iocp *)T->parm)->flip)
>          if (T->parm->msg_lev >= GLP_MSG_ALL)
>             xprintf("Long-step dual simplex will be used\n");
> #endif
>
> Please note that this change will appear in the next release of glpk.

Thank you!

>
>> Comment (by jdemeyer):
>>
>>  It would also be good to know what the message "Long-step dual simplex
>>  will be used" means. Is it supposed to be a warning to say that we are
>>  doing something wrong?
>>
>>
> Now (in glpk 4.65) it is an informational message, not warning.
>
> I again would like to repeat that parsing of the solver standard output
> to perform testing is not a good idea, because the glpk api does not
> specify it. If you say to me what namely do you need to test, I could
> suggest a more relevant test.
>

There's nothing in particular that needs to be tested. sagemath has tests for 
pretty much everything it can do and if it uses some library (and the library 
does not have some warnings or errors to report) one should just get sagemath's 
result of the calculation. It's just to test sagemath as a whole, other 
programs are expected to have their own tests etc.

Best,
Tobias






reply via email to

[Prev in Thread] Current Thread [Next in Thread]